mod_dav: add DavBasePath #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root path, useful where the DAV repos is configured with a regex match. * modules/dav/main/mod_dav.c (dav_get_resource): If available, pass the configured base path as the repos root to repos provider. On the error path for fetching a resource, detect and warn specifically when the location is configured via a regex. (dav_cmd_davbasepath): New function. PR: 35077 Github: closes apache#376 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1911651 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 8243437)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1911715 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit ed4cb1d)
tititiou36
reviewed
Aug 24, 2023
rpluem
reviewed
Aug 25, 2023
rpluem
reviewed
Aug 25, 2023
asfgit
pushed a commit
that referenced
this pull request
Aug 25, 2023
Submitted by: rpluem Github: pull #377 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1911907 13f79535-47bb-0310-9956-ffa450edef68
"conf" variable. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1911906 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 706af91)
Submitted by: rpluem Github: pull apache#377 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1911907 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 59c725a)
|
Thanks a lot for the reviews on this PR - updated now. |
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2023
Add DAVBasePath directive to allow users to configure the real repos root path, useful where the DAV repos is configured with a regex match. * modules/dav/main/mod_dav.c (dav_get_resource): If available, pass the configured base path as the repos root to repos provider. On the error path for fetching a resource, detect and warn specifically when the location is configured via a regex. (dav_cmd_davbasepath): New function. PR: 35077 Github: closes #377 Reviewed by: jorton, minfrin, rpluem Merge r1911715, r1911907 from trunk: Add docs for DavBasePath Fix documented default for DavBasePath to match code. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1912081 13f79535-47bb-0310-9956-ffa450edef68
|
Merged in ddd173b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.